Raise ValueError in Extract lookups that don't work properly with DurationField.

[cecedille1]

Lookups on ExtractYear on a DurationField fails because ExtractYear has an optimisation where it compares the source date with a range of dates.

class MyModel(models.Model):
    duration = models.DurationField()

MyModel.objects.annotate(year=ExtractYear('duration')).filter(year__gt=1)

The queryset generated looks like

SELECT * FROM mymodel WHERE duration > '0001-01-01'

and it fails because interval are not comparable with dates

[Simon Charette]

As I mentioned on the ticket Extract functions don't explicitly support DurationField; it's not documented nor tested. They happen to work for PostgreSQL because EXTRACT(component FROM ::interval) happens to work but that's just a coincidence.

I'm not sure if this ticket should be closed as invalid or repurposed as a feature request to add tested support. We'll have to come with with a way of defining units such as years though, do we want to consider them as 365.25 days?

[Mariusz Felisiak]

Support for DurationField to Extract was added in #27473, so it is a bug (see ​comment).

[Mariusz Felisiak]

​PR

[Mariusz Felisiak]

DurationField is modeled in Python by ​timedelta (see ​documentation), so even with this fix it will always return 0 for ExtractYear, ExtractMonth, or ExtractWeek which is unexpected. We should raise ValueError in all such cases.

[Hasan Ramezani]

​PR

[Mariusz Felisiak <felisiak.mariusz@…>]

In 402e6d29:

Fixed #30602 -- Made Extract raise ValueError when using unsupported lookups for DurationField.