Changes between Initial Version and Version 1 of Ticket #30427, comment 2
- Timestamp:
- May 7, 2019, 9:43:40 AM (5 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #30427, comment 2
initial v1 6 6 I've submitted a PR. Works, but it leaves a question around what we should be doing about `@attribute`-decorated methods. These slip under the radar of the `callable` check. So either we need to check for them separately, or we should rethink whether there's a point to preventing overriding of class methods in the first place. 7 7 8 Thoughts? Does anyone know why we were protecting classmethods in the first place, seems like we should be just letting the mro do its job and always override, no matter what it is we're overriding.8 Thoughts? Does anyone know why we were protecting classmethods? Seems like we should be just letting the mro do its job and always override, no matter what it is we're overriding.