Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#30332 closed Bug (fixed)

Postgres ordering ARRAY_AGG and STRING_AGG do not support expression. — at Version 4

Reported by: Simone Pellizzari Owned by: Simone Pellizzari
Component: Database layer (models, ORM) Version: 2.2
Severity: Release blocker Keywords: postgres string_agg array_agg ordering order by
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description (last modified by Simone Pellizzari)

I found that if you pass and expression as an ordering argument (introduced in https://github.com/django/django/commit/96199e562dcc409ab4bdc2b2146fa7cf73c7c5fe) an IndexError: tuple index out of range exception will be thrown when the query is executed.

This is caused by simply ignoring sql_params returned from as_sql calls on expressions contained built from ordering argument.

Change History (4)

comment:1 by Simone Pellizzari, 5 years ago

Description: modified (diff)

comment:2 by Simone Pellizzari, 5 years ago

Owner: changed from nobody to Simone Pellizzari
Status: newassigned

comment:3 by Simone Pellizzari, 5 years ago

Resolution: fixed
Status: assignedclosed

Opened a pull request that solves this: https://github.com/django/django/pull/11172

Last edited 5 years ago by Simone Pellizzari (previous) (diff)

comment:4 by Simone Pellizzari, 5 years ago

Description: modified (diff)
Note: See TracTickets for help on using tickets.
Back to Top