Opened 6 years ago
Last modified 6 years ago
#30328 closed Bug
Callable passed to Min/Max validators breaks in the fields — at Version 1
Reported by: | Harro | Owned by: | nobody |
---|---|---|---|
Component: | Database layer (models, ORM) | Version: | 2.2 |
Severity: | Release blocker | Keywords: | |
Cc: | Triage Stage: | Accepted | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | yes | Patch needs improvement: | yes |
Easy pickings: | yes | UI/UX: | no |
Description (last modified by )
in #29860 for django 2.2 the option was added to pass in a callable.
I just upgraded to django 2.2 and found our custom max value validator for current year + 1 (which gave us a migration on the year change) and thought to replace it with the new mechanic.
The result was the following error:
`
File "<venv>/lib/python3.6/site-packages/django/db/models/fields/init.py", line 1799, in <genexpr>
validator.limit_value <= max_value for validator in validators_)):
`
So the field wants to check that the validator's max (and min) value lie within range of the Integer field which is not possible with the callable.
The fix should be simple: Check if it's a callable and call it for the value.