Opened 6 years ago

Last modified 6 years ago

#30318 closed Bug

Add new system check message when custom error handler 'path.to.view' cannot be imported — at Version 3

Reported by: Alasdair Nicol Owned by: Alasdair Nicol
Component: Core (System checks) Version: 2.2
Severity: Release blocker Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description (last modified by Alasdair Nicol)

#29642 added checks for the signatures of custom error handlers.

When the 'path.to.view' cannot be imported, it raises ModuleNotFoundError or ViewDoesNotExist, as seen in this Stack Overflow question:

​https://stackoverflow.com/q/55481810/113962

I suggest we catch the exception, and add another check code, e.g.

* **urls.E008**: The custom ``handlerXXX`` view ``'path.to.view'`` cannot be imported.

Change History (3)

comment:1 by Alasdair Nicol, 6 years ago

Owner: changed from nobody to Alasdair Nicol
Status: new → assigned

comment:2 by Carlton Gibson, 6 years ago

Severity: Normal → Release blocker
Triage Stage: Unreviewed → Accepted
Type: Uncategorized → Bug

Hi Alasdair,

Thanks for the report, and the effort on StackOverflow. I'm happy to take this as improvement on the system check for 2.2.1. (Yes, catching an incorrect path is probably worthwhile.)

comment:3 by Alasdair Nicol, 6 years ago

Description: modified (diff)
Summary: Add new system check message when 'path.to.view' is cannot be imported → Add new system check message when custom error handler 'path.to.view' cannot be imported
Note: See TracTickets for help on using tickets.
Back to Top