Changes between Initial Version and Version 1 of Ticket #30272, comment 7


Ignore:
Timestamp:
Mar 28, 2019, 5:12:10 AM (5 years ago)
Author:
Carlton Gibson

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #30272, comment 7

    initial v1  
    33I'm going to provisionally accept this, but ask for a review from others.
    44
    5 Looking at 85a4844f8a8e628b90fa30ba7074f162a2d188ef, it's clear that we should (and do) serve the default language, ignoring `Accept-Language`, so, yes, plausibly, matching that in `get_language_from_request()`, when using `check_path`, would be correct.
     5Looking at 85a4844f8a8e628b90fa30ba7074f162a2d188ef, it's clear that we should (and do) serve the default language, ignoring `Accept-Language` in this kind of case, so, yes, plausibly, matching that in `get_language_from_request()`, when using `check_path`, would be correct.
    66
    77I've [https://github.com/django/django/pull/11123/commits/eaaa07ca971c2d19bc166e0750d043a49ba575fd added a very minimal port of the logic from `LocaleMiddleware` to `get_language_from_request()` on your PR]. Suitably tidied this might resolve the issue. (We'll see what CI says, but the change looks like it doesn't break anything...)
Back to Top