Changes between Version 2 and Version 3 of Ticket #30249, comment 6


Ignore:
Timestamp:
03/15/19 17:32:03 (4 years ago)
Author:
Carlton Gibson
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #30249, comment 6

    v2 v3  
    77So the other use is having your web server handle the 500 (or whatever) rather than Django doing it. Nothing to do with testing.
    88
    9 Now I know you're not suggesting we get rid of it. My point was that **as an action at a distance** setting controlling the exception handling behaviour, we might well want to phase it out at some point in the future.
     9Now I know you're not suggesting we get rid of it. My point was that **as an action at a distance** setting, controlling the exception handling behaviour, we might well want to phase it out at some point in the future.
    1010
    1111It was the **action at a distance** nature of it that I thought you would, equally to me, not be keen on.
    1212
    13 The point I (really!) imagined that we'd just agree on is that **action at a distance** type code is to be avoided. (Hence my use if "horrific" — using humour as I didn't think it a point where we wouldn't already agree.)
     13The point I (really!) imagined that we'd just agree on is that **action at a distance** type code is to be avoided. (Hence my use of "horrific" — using humour as I didn't think it a point where we wouldn't already agree.)
    1414
    1515So the relevance for your suggestion here is that I don't think **an action at a distance** use of a setting to control the behaviour of the test client is a good move. Rather, setting a flag on the test client — the `raise_request_exceptions` flag — is the right locus for this behaviour.
     
    2323This I understand. It's totally reasonable. (I'm not sure I agree yet but I understand the desire.)
    2424
    25 For me, the way to do this, if we want it, is to swap the default behaviour (i.e. change `raise_request_exceptions` from `True` to `False`)
     25For me, the way to do this, if we want it, is to swap the default behaviour of the existing flag (i.e. change `raise_request_exceptions` from `True` to `False`)
    2626
    2727So, can we agree that far? (That's a genuine question.)
Back to Top