UserManager.create_superuser doesn't allow for omitting email or password, unlike create_user which does.

[Joshua Cannon]

I couldn't find any historical information on whether or not this is intentional, but create_user/create_superuser seem to mirror each other except that create_superuser doesn't allow the caller to omit email and password parameters.
​This commit introduced omitting password, and ​this commit introduced omitting email, but neither touches create_superuser.

[Abhishek Bera]

I added a test case with no email and password for the super user which failed. later i changed the code in the models to email = None and password = None in the contrib/auth/models createsuperuser params.

[Tim Graham]

​The documentation says, The prototype of create_superuser() should accept the username field, plus all required fields as arguments." and "Unlike create_user(), create_superuser() must require the caller to provide a password."

For the default user mode, User.REQUIRED_FIELDS = ['email'] so that explains the original implementation. The documentation for CustomUserManager.create_user() wasn't updated after f54135fa4dc9fd45d86ea2944191d58e00725779. It still says, "The prototype of create_user() should accept the username field, plus all required fields as arguments." which is violated for the default case.

I don't have a strong opinion about how to proceed but if we proceed with the changes, some documentation changes are required.

[Carlton Gibson]

Just a couple of minor comments on the PR. Marking "Patch needs improvement", please uncheck that when those are addressed.

[Carlton Gibson <carlton.gibson@…>]

In b5a5c92c:

Fixed #30066 -- Enabled super user creation without email and password