Changes between Initial Version and Version 1 of Ticket #30064, comment 6


Ignore:
Timestamp:
01/24/2019 04:48:54 PM (11 months ago)
Author:
Simon Charette
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #30064, comment 6

    initial v1  
    11> I thought that the parameter of a single execution doesn't affect too much. when the validator is called, the same case about performance would happen here as well.
    22
    3 I think it's safe to assume every non-static or cached request handled by Django results in at least one database queries and that it isn't uncommon for queries to have at least one string parameter. Given these assumptions it's unlikely that performing a one time per admin changelist search request validation is ever going to have the same performance implications as performing a search and replace for every `'\x00'` string parameters provided to the ORM.
     3I think it's safe to assume every non-static or cached request handled by Django results in at least one database queries and that it isn't uncommon for queries to have at least one string parameter. Given these assumptions it's unlikely that performing a one time per admin changelist search request validation is ever going to have the same performance implications as performing a search and replace for every `'\x00'` string parameters thrown at the ORM.
    44
    55> Wouldn't it be better if a solution that also solves the raw query parameters? Users wouldn't have to check it out.
Back to Top