Changes between Initial Version and Version 1 of Ticket #30064, comment 10


Ignore:
Timestamp:
Jan 25, 2019, 9:12:52 AM (5 years ago)
Author:
Simon Charette

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #30064, comment 10

    initial v1  
    1 Hello Carl, it does look more appropriate. The page field should probably be a `forms.IntegerField` and you shouldn't have to perform any form of manual check for `'\x00'` as `forms.CharField` already has a `ProhibitNullCharactersValidator`. We'll have to find a way to surface the exception appropriately because raising it at `ChangeList` initialization will just result in a different crash.
     1Hello Can, it does look more appropriate. The page field should probably be a `forms.IntegerField` and you shouldn't have to perform any form of manual check for `'\x00'` as `forms.CharField` already has a `ProhibitNullCharactersValidator`. We'll have to find a way to surface the exception appropriately because raising it at `ChangeList` initialization will just result in a different crash.
Back to Top