Changes between Initial Version and Version 1 of Ticket #30043, comment 8


Ignore:
Timestamp:
Oct 2, 2019, 8:56:24 AM (5 years ago)
Author:
Brady

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #30043, comment 8

    initial v1  
    1 Hey Carlton,
     1Hey Carlton and Florian,
    22
    3 So I got close to thinking this was intractable essentially due to not being able to identify if the string had already been encoded or not. Specifically around the path that had been specified (I think this is where the original ticket came from, because during testing the %2F only became a problem when it was part of the path. Identified by the use case you showed above `smart_urlquote('%2F')` ) - Although I would think this is expected behavior in the sense that if you have %2F in the path, I would think you'd want that converted to a `/` anyways.
     3So I got close to thinking this was intractable essentially due to not being able to identify if the string had already been encoded or not. Specifically around the path that had been specified (I think this is where the original ticket came from, because during testing the `%2F` only became a problem when it was part of the path. Identified by the use case you showed above `smart_urlquote('%2F')` ) - Although I would think this is expected behavior in the sense that if you have `%2F` in the path, I would think you'd want that converted to a `/` anyways.
    44
    55I tried a few ways of handling this case without a special case, and could not come up with a viable solution, but once I added a check to see if the segment already contained `%2F` was I able to pass the tests. To be honest though, the more I think about it, the more I might have been coding to pass the tests as opposed to actually solving the problem. (I'm not actually sure what the real problem is, because the ticket author didn't provide a use case)
Back to Top