Changes between Initial Version and Version 1 of Ticket #29946


Ignore:
Timestamp:
Nov 12, 2018, 9:26:54 PM (5 years ago)
Author:
Tim Graham
Comment:

There are two changes between 1.11.14 and 1.11.16

In 1.11.15: d6eaee092709aad477a9894598496c6deec532ff - Fixed CVE-2018-14574 -- Fixed open redirect possibility in CommonMiddleware. In 1.11.16: 2668418d99b42599536d353705456cf5db718d48 - Fixed #29499 -- Fixed race condition in QuerySet.update_or_create().

It's not obvious how these fixes could be relevant to the code in question.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #29946 – Description

    initial v1  
    1414* During the same period after we took the Django upgrade, we started seeing this new exception in our error emails, which is in the database code for session updates and thus could be triggered by the changes in 1.11.16:
    1515
    16 ```
     16{{{
    1717Traceback (most recent call last):
    1818  File "/home/zulip/deployments/2018-11-12-02-10-23/zulip-py3-venv/lib/python3.5/site-packages/django/contrib/sessions/backends/db.py", line 87, in save
     
    4040    raise UpdateError
    4141django.contrib.sessions.backends.base.UpdateError
    42 ```
     42}}}
    4343
    4444I'm happy to do further debugging to help get to the bottom of this.
Back to Top