Allow icontains lookup to accept uuids with or without dashes

[Václav Řehák]

We have Django 2.1 project with model admin which includes an UUIDField in list_display and search_fields. The UUID is displayed with dashes on changelist (e.g. "245ba2eb-6852-47be-82be-7dc07327cf9e") and if the user cut'n'paste it to the search field, I would expect admin to find it.

This works however only on Postgres but fails on Oracle. I can understand why this happens (Oracle backend stores uuid as string) and I believe I can workaround it by customizing get_search_results but I think should be internal thing that Django handles gracefully - search should be possible by the value as displayed in admin.

[Tim Graham]

This isn't really an admin issue but rather it's due to the fact that the default admin lookup uses __icontains. You could fix the issue by using search_fields = ['uuidfield__exact'] (adding __exact) although that doesn't allow searching for part of the UUID value.

I'll tentatively accept the ticket to allow QuerySet.objects.filter(uuidfield__icontains='...') to work with values with or without dashes

[Václav Řehák]

Thank you for the quick answer. However, the proposed solution does not work as changing the uuid lookup to exact causes an error when searching for any string other than valid uuid value.

I get ValidationError raised from UUIDField.to_python()

File "/home/vaclav/.local/share/virtualenvs/aaa-yRfablWV/lib/python3.7/site-packages/django/db/models/fields/__init__.py" in to_python
  2325.                 return uuid.UUID(value)

File "/usr/lib/python3.7/uuid.py" in __init__
  160.                 raise ValueError('badly formed hexadecimal UUID string')

[Ian Foote]

​PR

[Mariusz Felisiak <felisiak.mariusz@…>]

In 485f65b:

Refs #29915 -- Added tests for using pattern lookups with values without hyphens for UUIDField.

[Mariusz Felisiak <felisiak.mariusz@…>]

In 343afa7:

Refs #29915 -- Doc'd limitation of using pattern lookups with UUIDField on PostgreSQL.

[Mariusz Felisiak <felisiak.mariusz@…>]

In d9881a02:

Fixed #29915 -- Added support for values with hyphens to pattern lookups for UUIDField on backends without UUID datatype.

Support hyphens in iexact, contains, icontains, startswith, istartswith,
endswith and iendswith UUIDField filters on backends without UUID
datatype.

[Mariusz Felisiak <felisiak.mariusz@…>]

In 368832e:

[3.0.x] Refs #29915 -- Doc'd limitation of using pattern lookups with UUIDField on PostgreSQL.

Backport of 343afa788080fb874bcd10eab1a1a2fede98c526 from master

[Mariusz Felisiak <felisiak.mariusz@…>]

In ae2dee6e:

[2.2.x] Refs #29915 -- Doc'd limitation of using pattern lookups with UUIDField on PostgreSQL.

Backport of 343afa788080fb874bcd10eab1a1a2fede98c526 from master