Changes between Initial Version and Version 1 of Ticket #29799, comment 8


Ignore:
Timestamp:
04/08/22 19:16:55 (8 months ago)
Author:
Carlton Gibson
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #29799, comment 8

    initial v1  
    55The specific behaviours are hard to say definitively one way or the other until we get to the review stage. Looking at test cases, and seeing how the API looks at that point is much easier to speak clearly to.
    66
    7 (For example, I'm not sure what to say about trying to unregister a non-registered lookup on a class... — we **could** error, or we could `pass`: the end effect is that the lookup is not registered on the class... 🤔 — it's the kind of detail we can settle with multiple sets of eyes at review time.)
     7(For example, I'm not sure what to say about trying to unregister a non-registered lookup on a class... — we **could** error, or we could `pass`: the end effect is that the lookup is not registered on the class... — My query would be **why** an error? 🤔 — it's the kind of detail we can settle with multiple sets of eyes at review time.)
    88
    99I know you're looking at this targeting GSoC, so for the the sake of a proposal, noting the areas to be decided is OK. Showing that you've considered points already raised is important — make sure you looked at [https://github.com/django/django/pull/15529#issuecomment-1073412321 Simon's comment on your draft PR] — I'm sure you did. Plus #33626 and the PR there you've made are all good signs — that's on my list to review next week.
Back to Top