Changes between Initial Version and Version 1 of Ticket #29505, comment 3
- Timestamp:
- Nov 16, 2018, 2:05:01 PM (5 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #29505, comment 3
initial v1 1 I believe the proposed patch would break callable defaults. In `effective_defau tl()`, `field.get_default()` may return a callable and `Field.get_prep_value()` won't work properly if it receives a callable instead of a value. I guess test coverage is lacking.1 I believe the proposed patch would break callable defaults. In `effective_default()`, `field.get_default()` may return a callable and `Field.get_prep_value()` won't work properly if it receives a callable instead of a value. I guess test coverage is lacking. 2 2 3 3 I think you should change your `__call__()` method to make `other` an optional argument.