Changes between Initial Version and Version 2 of Ticket #29493


Ignore:
Timestamp:
Jun 14, 2018, 8:24:53 AM (6 years ago)
Author:
Carlton Gibson
Comment:

This is expected behaviour. You pass __in an iterable, a string is an iterable. It's not the desired result, I grant you, but it's just Python.

So first, this isn't a Release Blocker. At best it's a bug, of normal severity.

I'm going to class it as a "New Feature" though because you're basically asking to add type checking here, to make sure you pass the right kind of iterable. (i.e. not a string.)

For that I'm going to say wontfix. I strongly suspect it wouldn't be worth the effort (i.e the added code would be worse than the problem it's guarding against.) It's also quite likely that there are use-cases where being able to pass a string (as an iterable) is the desired behaviour: there will be people somewhere using that.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #29493

    • Property Resolutionwontfix
    • Property Severity Release blockerNormal
    • Property Status newclosed
    • Property Summary ORM: [fieldname]__in when passed a string iterates over digits of the stringBlock strings from being passed to `__in`
    • Property Type UncategorizedNew feature
  • Ticket #29493 – Description

    initial v2  
     1ORM: [fieldname]__in when passed a string iterates over digits of the string
     2
    13Can be reproduced in a virgin new project with `django-admin startproject mysite`
    24Django version 1.11.13, python version 2.7
Back to Top