cached_property decorator doesn't work with mangled method names

[Thomas Grainger]

import itertools

from django.utils.functional import cached_property

count = itertools.count()
count2 = itertools.count()
count3 = itertools.count()


class Foo:
    @cached_property
    def __foo(self):
        return next(count)

    @cached_property
    def foo2(self):
        return next(count2)

    @property
    def foo3(self):
        return next(count3)

    def run(self):
        print('foo', self.__foo)
        print('foo', self.__foo)
        print('foo', self.__foo)
        print('foo', self.__foo)
        print('foo2', self.foo2)
        print('foo2', self.foo2)
        print('foo2', self.foo2)
        print('foo2', self.foo2)
        print('foo2', self.foo2)
        print('foo3', self.foo3)
        print('foo3', self.foo3)
        print('foo3', self.foo3)
        print('foo3', self.foo3)
        print('foo3', self.foo3)


Foo().run()


"""
python cached_property_test.py 
foo 0
foo 1
foo 2
foo 3
foo2 0
foo2 0
foo2 0
foo2 0
foo2 0
foo3 0
foo3 1
foo3 2
foo3 3
foo3 4
"""

Odd it's not been reported before: https://code.djangoproject.com/search?q=cached_property+mangled

[Tim Graham]

​PR

[Harro]

Had a look at this, and the Foo instance dict does contain the foo (and the foo2, but not the foo3 as expected).

I think this is more a python thing where the double underscore is special and that is the reason it doesn't work and that it has nothing to do with the @cached_property decorator.

[Tim Graham <timograham@…>]

In 09199734:

Refs #29478 -- Doc'd how to use cached_property with a mangled name.

[Tim Graham <timograham@…>]

In 2a637a45:

[2.1.x] Refs #29478 -- Doc'd how to use cached_property with a mangled name.

Backport of 09199734d383691ecf6d163894b447ca45e0ef82 from master

[Tim Graham <timograham@…>]

In 80ba7a8:

Fixed cached_properties that share a common property.

The aliases aren't cached and thus the old usage will be an error after
refs #29478.

[Tim Graham <timograham@…>]

In 06076999:

Fixed #29478 -- Added support for mangled names to cached_property.

Co-Authored-By: Sergey Fedoseev <fedoseev.sergey@…>

[Tim Graham <timograham@…>]

In 3b64e2b7:

Refs #29478 -- Clarified cached_property 2.2 release note.

[Tim Graham <timograham@…>]

In c3655b1:

[2.2.x] Refs #29478 -- Clarified cached_property 2.2 release note.

Backport of 3b64e2b77570c73a0d7092124fa73439e0fb4305 from master.