Changes between Initial Version and Version 1 of Ticket #29430, comment 4


Ignore:
Timestamp:
May 24, 2018, 2:31:47 PM (6 years ago)
Author:
Sub

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #29430, comment 4

    initial v1  
    33See lines 127-128: https://github.com/django/django/blob/5a6f70b4281817656db2f36c5919036d38fcce7f/django/core/mail/backends/smtp.py
    44
    5 The exception to be raised in this case is smtplib.SMTPException. I agree that it does not guarantee that this exception will be raised, and could be misinterpreted. Maybe it would be clearer as "If it’s False, send_mail will raise an smtplib.SMTPException if an error occurs." I think it should definitely be explaining the False case, (not True) as we want to explain the what happens if the failure isn't ignored.
     5The exception to be raised in this case is smtplib.SMTPException. I agree that it does not guarantee that this exception will be raised, and could be misinterpreted. Maybe it would be clearer as "If it’s False, send_mail will raise an smtplib.SMTPException when an error occurs." I think it should definitely be explaining the False case, (not True) as we want to explain the what happens if the failure isn't ignored.
    66
    77Replying to [ticket:29430 ティン・ルーフ]:
Back to Top