Opened 7 years ago
Last modified 7 years ago
#29348 closed Cleanup/optimization
"-" and "_" in language code should be consistent — at Version 1
| Reported by: | Shen Li | Owned by: | nobody |
|---|---|---|---|
| Component: | Internationalization | Version: | 2.0 |
| Severity: | Normal | Keywords: | i18n, inconsistency |
| Cc: | Triage Stage: | Unreviewed | |
| Has patch: | no | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description (last modified by )
for some languages eg, en-us hyphen is used
but in zh_hans underscore is used.
If zh-hans is used, django would not show the translation. Here's some tests and resutls
Language code: zh_hans, folder zh_hans -> works
Language code: zh_hans, folder zh-hans -> No translation files found for default language zh_hans.
Language code: zh-hans, folder zh-hans -> does not work. No errors, no translations
Language code: zh-hans, folder zh_hans -> does not work. No erros, no translations
looks like django does not treat zh-hans as a valid language code, which is very very confusing because the default en-us is valid.
It look me a very long time to figure this out.
Edit: even zh_hans is not working with browser language detection, the folder has to be named 'zh_Hans' even though request.LANGUAGE is 'zh-hans'
is there somether in the doc that pointed this out?