Changes between Initial Version and Version 3 of Ticket #29346
- Timestamp:
- Apr 20, 2018, 2:07:40 PM (7 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #29346
- Property Easy pickings set
-
Ticket #29346 – Description
initial v3 14 14 My proposal is to add a kwarg `intermediary` to `ModelForm._save_m2m`. This kwarg behaves exactly like `self._meta.exclude` within `ModelForm._save_m2m`. 15 15 16 I have already created a github branch with my solution, but have not created a pull request per contribution guidelines (but will do so if/when this ticket is approved). My solution adds three/four (3/4) lines of code, denoted in my solution below with EOL comment `# ADDED`. I believe my simple solution is more appropriate than a complex introspective analysis of every potential ManyToManyField's 'through' attribute.16 I have already created a github branch (https://github.com/denhartog/django/tree/ticket_29346_2_0) with my solution, but have not created a pull request per contribution guidelines (but will do so if/when this ticket is approved). My solution adds three/four (3/4) lines of code, denoted in my solution below with EOL comment `# ADDED`. I believe my simple solution is more appropriate than a complex introspective analysis of every potential ManyToManyField's 'through' attribute. 17 17 18 18 The final code of my proposal is (in django.forms.models):