non_atomic_requests decorator alters _non_atomic_requests attribute of original function

[Alasdair Nicol]

When calling non_atomic_requests with a function, it alters the _non_atomic_requests attribute of the original function.

Here's an example:

from django.test import TestCase

# Create your tests here.

from django.test import TestCase
from django.db import transaction

@transaction.non_atomic_requests(using='default')
def my_view(request):
        return HttpResponse('')

class TestViews(TestCase):

    def test(self):
        assert my_view._non_atomic_requests == {'default'}  # passes

        wrapped_view = transaction.non_atomic_requests(using='other')(my_view)

        assert wrapped_view._non_atomic_requests == {'default', 'other'}  # passes
        assert my_view._non_atomic_requests == {'default'}  # fails

I realise that this is a contrived example. It isn't an issue when non_atomic_requests is used as a decorator:

@transaction.non_atomic_requests(using='default')
@transaction.non_atomic_requests(using='other')
def my_view(request)
    return HttpResponse('')

[Tim Graham]

I'm not able to reproduce. I created this test file:

from django.test import TestCase
from django.db import transaction

@transaction.non_atomic_requests(using='default')
def my_view(request):
    return HttpResponse('')

class TestViews(TestCase):

    def test(self):
        assert my_view._non_atomic_requests == {'default'}  # passes

        wrapped_view = transaction.non_atomic_requests(using='other')

        assert wrapped_view._non_atomic_requests == {'default', 'other'}  # passes
        assert my_view._non_atomic_requests == {'default'}  # fails

I get:

Traceback (most recent call last):
  File "/home/tim/code/mysite/polls/test_29303.py", line 15, in test
    assert wrapped_view._non_atomic_requests == {'default', 'other'}  # passes
AttributeError: 'function' object has no attribute '_non_atomic_requests'

and if I remove the assertion, the next assertion passes.

[Alasdair Nicol]

Sorry, there was a mistake in the wrapped_view line, I didn't apply it to the view. It should be:

wrapped_view = transaction.non_atomic_requests(using='other')(my_view)

I've updated the example in the ticket description.