Opened 8 years ago
Last modified 7 years ago
#29303 new Bug
non_atomic_requests decorator alters _non_atomic_requests attribute of original function — at Initial Version
| Reported by: | Alasdair Nicol | Owned by: | nobody |
|---|---|---|---|
| Component: | Database layer (models, ORM) | Version: | dev |
| Severity: | Normal | Keywords: | |
| Cc: | Triage Stage: | Accepted | |
| Has patch: | no | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
When calling non_atomic_requests with a function, it alters the _non_atomic_requests attribute of the original function.
Here's an example:
from django.db import transaction
@transaction.non_atomic_requests(using='default')
def my_view(request):
return HttpResponse('')
assert my_view._non_atomic_requests == {'default'} # passes
wrapped_view = transaction.non_atomic_requests(using='other')
assert wrapped_view._non_atomic_requests == {'default', 'other'} # passes
assert my_view._non_atomic_requests == {'default'} # fails
I realise that this is a contrived example. It isn't an issue when non_atomic_requests is used as a decorator:
@transaction.non_atomic_requests(using='default')
@transaction.non_atomic_requests(using='other')
def my_view(request)
return HttpResponse('')
Note:
See TracTickets
for help on using tickets.