Opened 7 years ago
Last modified 13 months ago
#29214 new Bug
Invalid SQL when updating after annotating using subquery — at Version 1
Description (last modified by ) ¶
An SQL-error is raised when updating a queryset which includes an annotation created using a subquery, which in turn also uses an annotation.
class Recursive(models.Model): name = models.CharField(max_length=10) link = models.IntegerField() parent = models.ForeignKey('self', models.CASCADE, null=True) from django.db.models import OuterRef, Subquery, F rec1 = Recursive.objects.create(name="r1", link=1) rec2 = Recursive.objects.create(name="r2", link=1) rec3 = Recursive.objects.create(name="r11", parent=rec1, link=2) latest_parent = Recursive.objects.filter(link=OuterRef('parent_link')).order_by('id') Recursive.objects.filter(parent__isnull=False) \ .annotate(parent_link=F('parent__link')) \ .annotate(p=Subquery(latest_parent.values('pk')[:1])) \ .update(parent_id=F('p'))
Traceback (most recent call last): File "tests.py", line 88, in test_update_annotated_using_related_queryset .update(parent_id=F('p')) File "/git/django/django/db/models/query.py", line 647, in update rows = query.get_compiler(self.db).execute_sql(CURSOR) File "/git/django/django/db/models/sql/compiler.py", line 1204, in execute_sql cursor = super(SQLUpdateCompiler, self).execute_sql(result_type) File "/git/django/django/db/models/sql/compiler.py", line 899, in execute_sql raise original_exception OperationalError: no such column: T2.link
I've tried this in SQLite and MySQL in Django 1.11.11 and Django 2.0 using Python 3.6.0. All raising similar errors.
According to the ticket's flags, the next step(s) to move this issue forward are:
- To improve the patch as described in the pull request review comments or on this ticket, then uncheck "Patch needs improvement".
If creating a new pull request, include a link to the pull request in the ticket comment when making that update. The usual format is:
[https://github.com/django/django/pull/#### PR]
.
Change History (1)
comment:1 by , 7 years ago
Description: | modified (diff) |
---|---|
Summary: | SQL-error when updating after annotating using subquery → Invalid SQL when updating after annotating using subquery |
Triage Stage: | Unreviewed → Accepted |
Reproduced at feb683c4c2c5ecfb61e4cb490c3e357450c0c0e8.