Changes between Initial Version and Version 1 of Ticket #28860, comment 8
- Timestamp:
- Dec 3, 2017, 5:05:18 AM (7 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #28860, comment 8
initial v1 2 2 3 3 In db/backends/oracle/creation.py the cast to {{{allow_quiet_fail = bool (acceptable_ora_err)}}} is superfluous, as the called _execute_statements(... allow_quiet_fail=allow_quiet_fail)}}} just calls {{{if not allow_quiet_fail...}}}. Hence calling {{{self._execute_statements(cursor, statements, parameters, verbosity, allow_quiet_fail=acceptable_ora_err)}}} and deleting the local variable {{{allow_quiet_fail}}} is reasonable. 4 5 In django/db/backends/postgresql/operations.py the code can be shortened to {{{column_name = sequence_info['column'] or 'id'}}}.