Opened 7 years ago
Last modified 5 years ago
#28750 closed Bug
Django 2.0 should permit Meta.manager_inheritance_from_future — at Version 1
| Reported by: | Charlie Denton | Owned by: | nobody |
|---|---|---|---|
| Component: | Database layer (models, ORM) | Version: | 2.0 |
| Severity: | Release blocker | Keywords: | |
| Cc: | Triage Stage: | Accepted | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description (last modified by )
I'm trying to make a library compatible with both django 1.11 and 2.0b1, but I've hit something of a snag.
I have added manager_inheritance_from_future to the Meta class of my base model, which removes the following warning:
RemovedInDjango20Warning: Managers from concrete parents will soon qualify as default managers if they appear before any other managers in the MRO. ...you can switch to the new behavior right away by setting
Meta.manager_inheritance_from_futuretoTrue.
So far so good, unfortunately, now that I've added that for django 1.11, I'm getting this error on django 2.0b1:
TypeError: 'class Meta' got invalid attribute(s): manager_inheritance_from_future
The manager_inheritance_from_future option was removed in 631f4ab06112aca5bd6a57b81159048f936050bf, but this is pretty frustrating. I'm not sure how to make this library compatible with both versions, as a result of this.
Perhaps this removal was premature?