Changes between Initial Version and Version 1 of Ticket #28646, comment 9


Ignore:
Timestamp:
Mar 12, 2018, 1:12:24 PM (6 years ago)
Author:
Carlton Gibson

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #28646, comment 9

    initial v1  
    11Comments on PR: we have an error in the boolean logic, not correctly distinguishing between the `_unique` and `primary_key` cases.
    22
     3Making the check target `_unique` is enough to avoid the issue:
     4
     5
     6{{{
     7        if ((not (old_field.db_index or old_field.unique) and new_field.db_index) or
     8                (not old_field.unique and new_field._unique)):
     9}}}
     10
     11
    312(The original suggestion leads to just 3 failures a fix should be simple enough...)
Back to Top