Opened 8 years ago
Last modified 8 years ago
#28550 closed Bug
LogoutView loses template_name — at Initial Version
| Reported by: | Clayton Daley | Owned by: | nobody |
|---|---|---|---|
| Component: | contrib.auth | Version: | 1.11 |
| Severity: | Release blocker | Keywords: | |
| Cc: | Zach Liu | Triage Stage: | Accepted |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | yes | UI/UX: | no |
Description
I'm using django-userena which passes a custom template name into
return Signout(request, next_page, template_name, *args, **kwargs)
By the time this call is converted to a view, the template_name reverts to the default (registration/logged_out.html). If I convert the arg to a kwarg (in userena), the call works correctly so the issue seems to be the way the view is constructed (in contrib.auth.views.logout():
return LogoutView.as_view(**kwargs)(request, *args, **kwargs)
Since template_name is passed as an arg, it isn't included in the call to as_view() that actually sets attributes (including template_name. Before making this call, I suspect the logout() function should convert template_name (and possibly other args) into kwargs.