Changes between Initial Version and Version 1 of Ticket #28209, comment 5


Ignore:
Timestamp:
May 15, 2017, 3:09:15 PM (7 years ago)
Author:
Adit Biswas

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #28209, comment 5

    initial v1  
    11Sorry, I'm not sure if I've done enough. Waiting for some discussion around this before I continue making changes.
    22basically datetime will throw value errors whenever the year crosses 9999.
    3 Wherever a datetime is manipulated to increment the date to cross 10000 will be affected.
     3Wherever a datetime is manipulated to the date to cross year 10000 will be affected.
    44
    55{{{
    … …  
    88DayMixin._get_next_day(self, date)
    99WeekMixin._get_next_week(self, date)
     10DateMixin._make_date_lookup_arg(self, value)
    1011}}}
    1112While 404 would be an appropriate response for dates crossing the Year 9999
    … …  
    1314if I throw 404 for each mixin the behaviour will be slightly odd. since
    1415''/dates/books/9999/'' will throw a 404 but ''/dates/books/9999/01'' will not
     16
     17In case of DateMixin._make_date_lookup_arg method, the datetime object does not actually throw an error, but it behaves in an unexpected way and cycles to a different date altogether
     18eg. /dates/books/10000/ causes the date argument to become the 2008 but the view will not return a 500.
Back to Top