Changes between Initial Version and Version 2 of Ticket #28188
- Timestamp:
- 05/09/17 12:47:46 (5 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #28188
-
Property
Status
changed from
new
toassigned
-
Property
Severity
changed from
Normal
toRelease blocker
-
Property
Component
changed from
Uncategorized
toDatabase layer (models, ORM)
-
Property
Summary
changed from
Field._get_default prevents model fields from being pickled
toField._get_default() prevents model fields from being pickled
- Property Owner changed from nobody to Adam Alton
-
Property
Type
changed from
Uncategorized
toBug
-
Property
Triage Stage
changed from
Unreviewed
toAccepted
-
Property
Status
changed from
-
Ticket #28188 – Description
initial v2 13 13 My proposed solution is to simply move the ''if callable()'' check back out into the ''get_default'' method. This would mean that we lose a very minor bit of efficiency because we have to run that one ''if'' statement each time that ''get_default'' is called, but the rest of the logic would remain inside the cached ''_get_default'' method. 14 14 15 I have made a commit here which contains my proposed fix and a test to prevent regression: https://github.com/adamalton/django/commit/ a7c3f672d2ea45df2fdea8cad6ffcfa10172b13315 I have made a commit here which contains my proposed fix and a test to prevent regression: https://github.com/adamalton/django/commit/ee6aafacfd01f2603943e8c4183805fd4a298355 16 16