Changes between Initial Version and Version 1 of Ticket #28159


Ignore:
Timestamp:
05/01/2017 08:25:42 PM (5 years ago)
Author:
Tim Graham
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #28159

    • Property Severity changed from Normal to Release blocker
    • Property Summary changed from Fix issues with InlineFormset.save_as_new in Django 1.11 to Using InlineFormset.save_as_new crashes in Django 1.11
    • Property Needs tests set
    • Property Triage Stage changed from Unreviewed to Accepted
  • Ticket #28159 – Description

    initial v1  
    1 Django 1.11 now marks multipart POST data as immutable [(Release notes section)](https://docs.djangoproject.com/en/1.11/releases/1.11/#miscellaneous). This causes an issue with the private ``save_as_new`` feature in InlineFormsets: the set code in the conditional block [here](https://github.com/django/django/blob/master/django/forms/models.py#L886) now throws an AttributeError because the data it's attempting to change is marked as immutable.
     1Django 1.11 marks multipart POST data as immutable: 4a246a02bdcbc13b15480c014f51cb0682af7c1e (#17235) . This causes an issue with the private `save_as_new` feature in InlineFormsets: the set code in the conditional block in [https://github.com/django/django/blob/05098fa4494e66e1d3750d7f4821f7b3114693b9/django/forms/models.py#L886 BaseInlineFormSet._construct_form()] now raises `AttributeError` because the data it's attempting to change is marked as immutable.
    22
    3 To restore previous behavior, this pull request turns off the immutability flag on the form data while the save_as_new functionality runs and turns immutability back on when the mutation code is complete.
     3To restore previous behavior, [https://github.com/django/django/pull/8448 this pull request] turns off the immutability flag on the form data while the save_as_new functionality runs and turns immutability back on when the mutation code is complete.
    44
    5 Note that the mutable flag isn't set if there is no data, hence the ``hasattr`` code.
    6 
    7 PR: https://github.com/django/django/pull/8448
     5Note that the mutable flag isn't set if there is no data, hence the `hasattr` code.
Back to Top