Changes between Version 2 and Version 3 of Ticket #28104, comment 4


Ignore:
Timestamp:
May 6, 2017, 9:50:58 PM (8 years ago)
Author:
Josh Schneier

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #28104, comment 4

    v2 v3  
    11I looked into this and implemented option 2 but just want to note that the RFC link applies only to `PUT` ''in particular''. `POST` and other unsafe methods can return validator headers as discussed in [https://tools.ietf.org/html/rfc7231#section-7.2 Section 7.2].
    22
    3 I do agree that computing it for POST would make the code a bit ugly due to needing to run the functions twice and can be thought of as a new feature (I haven't thought through the feasibility that much yet) instead of the bug which is this. I could also use some help framing this in documentation (does it warrant a ..versionchanged, technically it does change things so I wasn't sure if it should go in 1.11 or not).
     3I do agree that computing it for `POST` would make the code a bit ugly due to needing to run the functions twice and can be thought of as a new feature (I haven't thought through the feasibility that much yet) instead of the bug which is this. I could also use some help framing this in documentation (does it warrant a `..versionchanged`, technically it does change things so I wasn't sure if it should go in 1.11 or not).
    44
    55[https://github.com/django/django/pull/8468 PR]
Back to Top