Changes between Initial Version and Version 1 of Ticket #28021


Ignore:
Timestamp:
Apr 5, 2017, 7:42:38 AM (7 years ago)
Author:
Tim Graham
Comment:

I'm not sure if this has much value considering that ModelBackend and RemoteUserBackend reject inactive users (as of Django 1.10, see #25232). Would this decorator change behavior in any way?

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #28021

    • Property Easy pickings unset

  • Ticket #28021 – Description

    initial v1  
    1212"is_active is a hook for custom auth sources and custom auth logic; the built-in stuff doesn't check it. Yes it's a bit counter-intuitive, but changing it is going to break a number of expectations in users' code, so it's going to need to stay as is."
    1313
    14 As a solution, I'd like to add an active_login_required decorator, which does check for is_active = True. That way we maintain backwards compatibility and in addition we can have a decorator that behaves intuively.
     14As a solution, I'd like to add an active_login_required decorator, which does check for is_active = True. That way we maintain backwards compatibility and in addition we can have a decorator that behaves intuitively.
Back to Top