Opened 7 years ago

Last modified 7 years ago

#28020 closed Cleanup/optimization

make GEOSGeometry.json use OGRGeometry.json again (for performance reasons) — at Version 2

Reported by: Sergey Fedoseev Owned by: Sergey Fedoseev
Component: GIS Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description (last modified by Sergey Fedoseev)

GEOSGeometry.json was using OGRGeometry.json prior to 1.9. That was changed in #25141. Now GDAL is required (#26753) and I believe we should restore previous GEOSGeometry.json implementation for performance reasons:

In [67]: ls = LineString([(x, x) for x in range(1000)])

In [68]: %timeit ls.json
10 loops, best of 3: 42.6 ms per loop

In [69]: %timeit ls.ogr.json
100 loops, best of 3: 3.75 ms per loop

Change History (2)

comment:1 by Sergey Fedoseev, 7 years ago

Owner: changed from nobody to Sergey Fedoseev
Status: newassigned

comment:2 by Sergey Fedoseev, 7 years ago

Description: modified (diff)
Note: See TracTickets for help on using tickets.
Back to Top