BrinIndex crashes if name > 30 characters

[Den]

BrinIndex.suffix ( django.contrib.postgres.indexes) longer 3 char, but Index.set_name_with_model method allowed 3 char in suffix

AssertionError: Index too long for multiple database support. Is self.suffix longer than 3 characters?

[Markus Holtermann]

There are no tests for auto-generated index names as there are for GinIndex: ​https://github.com/django/django/blob/master/tests/postgres_tests/test_indexes.py#L61-L64

[Mads Jensen]

The current model wasn't actually enough to trigger a failure for the auto-generated name as the length of the indexed field is only 5 characters.

Either changing suffix = brin to suffix = brn`, or removing a character from the hash so it's just five characters. Probably the first is better?

def test_name_auto_generation_fail(self):
    # name of field must be at least 7 characters long to get to 30 characters
    index = BrinIndex(fields=['datetimes'])
    index.set_name_with_model(DateTimeArrayModel)
    self.assertEqual(index.name, 'postgres_te_datetim_b1e2ca_brn')

[Mads Jensen]

​PR

[Tim Graham <timograham@…>]

In 82bb4e68:

Fixed #27935 -- Fixed crash with BrinIndex name > 30 characters.

[Tim Graham <timograham@…>]

In 0b93a992:

[1.11.x] Fixed #27935 -- Fixed crash with BrinIndex name > 30 characters.

Backport of 82bb4e684f9d0e5939cb0596c249954df0888e2d from master

[Tim Graham]

Florian pointed out on IRC that in a mixed database setup, connection.ops.max_name_length() won't necessarily be a PostgreSQL connection. Maybe that could use the db.backends.postgresql.operations.DatabaseOperations class instead.

[Tim Graham <timograham@…>]

In 2867b7eb:

Refs #27935 -- Fixed BrinIndex.max_name_length if a project's default database isn't PostgreSQL.

Thanks Florian Apolloner for the report.

[Tim Graham <timograham@…>]

In 40b84348:

[1.11.x] Refs #27935 -- Fixed BrinIndex.max_name_length if a project's default database isn't PostgreSQL.

Thanks Florian Apolloner for the report.

Backport of 2867b7eb4b8477710f11707d4b975db10e5f91a7 from master