Opened 8 years ago
Last modified 7 years ago
#27858 closed Cleanup/optimization
makemigrations shouldn't attempt to create django_migrations table — at Initial Version
| Reported by: | Marti Raudsepp | Owned by: | Marti Raudsepp |
|---|---|---|---|
| Component: | Migrations | Version: | 1.10 |
| Severity: | Normal | Keywords: | makemigrations |
| Cc: | Triage Stage: | Accepted | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | yes |
| Easy pickings: | no | UI/UX: | no |
Description
In multiple different projects now, I've needed to connect Django to legacy databases that aren't under Django's control. Even when setting "manage = False" in all affected models and configuring the DB router to never allow migrate in the legacy database, Django "makemigrations" still attempts to create the django_migrations table, causing permission errors in my use case.
The pull request changes MigrationRecorder is so that for read-only operations, if the django_migrations table doesn't exist, it's assumed that no migrations have been applied, instead of trying to create it. This applies to all migration commands.
Django has always had the problem of being "opinionated", meaning there's often fighting involved if you don't exactly follow The True Django way. :) This patch is a small step in making Django more flexible.
PS: I understand that version 1.11 is alreday in a feature freeze, but is there aaaaany chance of getting this patch in there?