Changes between Version 3 and Version 4 of Ticket #27658


Ignore:
Timestamp:
Dec 30, 2016, 3:12:20 AM (7 years ago)
Author:
Paolo Dente
Comment:

@Tim: as far as I can tell, any non-local storage should be affected so a possible test would require mocking Storage or the management command so that Command.local() is False; I can try and write one. On the other hand, it looks like @Vitali spotted the problem with the refactoring, so I don't know how to proceed from here.

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #27658 – Description

    v3 v4  
    1 @Tim: as far as I can tell, any non-local storage should be affected so a possible test would require mocking Storage or the management command so that Command.local() is False; I can try and write one. On the other hand, it looks like @Vitali spotted the problem with the refactoring, so I don't know how to proceed from here.
     1The change to django/contrib/staticfiles/management/commands/collectstatic.py in commit 2cd2d188516475ddf256e6267cd82c495fb5c430 causes the command to overwrite all static files in remote storage (eg. S3), instead of only updatable ones.
     2
     3A quick workaround is to override the command and restore the previous Command.delete_file() in the subclass, but I suppose this should be fixed.
Back to Top