Changes between Initial Version and Version 1 of Ticket #27604, comment 8


Ignore:
Timestamp:
Jun 22, 2019, 2:32:19 AM (5 years ago)
Author:
Florian Apolloner

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #27604, comment 8

    initial v1  
    1 >  However, as I've never left messages in storage for more than one or two request-response cycles, option 1 strikes me as reasonable and much cleaner.
     1Replying to [comment:6 Craig Anderson]:
     2> However, as I've never left messages in storage for more than one or two request-response cycles, option 1 strikes me as reasonable and much cleaner.
    23
    34this is true, but even "just for one request" can be an issue for large sites. The safest bet is option two where we keep the dual decoding for a whole LTS period and then drop it. Given that 2.2 is already out and we cannot really safely introduce any new changes there I think we should merge option 2 into master and remove the second codepath in 4.2. This would mean that people upgrading from 2.2 (LTS) -> 3.2 (LTS) -> 4.2 (LTS) would not have (many) issues unless they directly jump from 2.2 -> 4.2
Back to Top