Changes between Initial Version and Version 1 of Ticket #27539, comment 8
- Timestamp:
- Feb 1, 2017, 11:56:10 AM (8 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #27539, comment 8
initial v1 1 So I have been working on this ticket and I have a question. Should the check to see if the ```len(self.queries_log) >= self.queries_log.maxlen``` be put in the make_debug_cursor or should it be put in the base of the CursorDebugWrapper class? If we put it in CursorDebugWrapper we will need to have all the executesql statements between a try and catch block. 1 So I have been working on this ticket and I have a question. Should the check to see if the ```len(self.queries_log) >= self.queries_log.maxlen``` be put in the make_debug_cursor or should it be put in the base of the CursorDebugWrapper class? If we put it in CursorDebugWrapper we will need to have all the executesql statements between a try and catch block. Currently the check is placed in the make_debug_cursor and an Exception is thrown once the ```len(self.queries_log) >= self.queries_log.maxlen```. Another question I have is whether I should throw an exception or I should just clear the queries_log. If I use clear the assertNumQueries test fails.