#27485 closed New feature (wontfix)
Allow ALLOWED_HOSTS to accept an IP-range / wildcard
Reported by: | Tom Turner | Owned by: | nobody |
---|---|---|---|
Component: | HTTP handling | Version: | 1.10 |
Severity: | Normal | Keywords: | ALLOWED_HOSTS |
Cc: | Triage Stage: | Accepted | |
Has patch: | no | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
Hi
Now that Django 1.10.3 forces ALLOWED_HOSTS on with debug I have a problem.
The problem is that when I developing I use an ip-address range of 192.168.1.*.
The Ip-adress can change depending on the computer I use.
so I required the ability to add wildcard partly in an hostname.
ie
ALLOWED_HOSTS = ['192.168.1.*', '.mydomain.com']
I have seen this solution that doesn't require Django to be changed however I don't like it as I feel this could be a secuirty issue
http://stackoverflow.com/questions/37031749/django-allowed-hosts-ips-range
I am happy to produce a patch however I will only do this if it's likely to get submitted
Change History (2)
comment:1 by , 8 years ago
Component: | Uncategorized → HTTP handling |
---|---|
Summary: | ALLOWED_HOSTS ip-range / wildcard → Allow ALLOWED_HOSTS to accept an IP-range / wildcard |
Triage Stage: | Unreviewed → Accepted |
comment:2 by , 8 years ago
Resolution: | → wontfix |
---|---|
Status: | new → closed |
After posting on the group there are way round the problem.
The one I going with is
from socket import gethostname, gethostbyname ALLOWED_HOSTS = [ gethostname(), gethostbyname(gethostname()), ]
I'm sympathetic to the use case, however, before coding I think it'd be good to raise the idea on the DevelopersMailingList to ensure no one sees a problem with it or has an alternative.