Changes between Version 1 and Version 2 of Ticket #27263, comment 10


Ignore:
Timestamp:
Sep 26, 2016, 7:10:18 AM (8 years ago)
Author:
Alexey Rogachev

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #27263, comment 10

    v1 v2  
    1 The name of parameter (`show_circuit_validation`) is approximate, can be discussed and changed. I disagree that it covers specific use case. It's needed quite often, and in my opinion it's more logical than apply all validators one by one regardless of previous errors and should be default strategy. I'm not sure that creating a wrapper validator will be a good solution because validators in set can vary. Also this will require to change the way it's defined or subclass fields to override this logic, because this is defined in field.
     1The name of parameter (`show_circuit_validation`) is approximate, can be discussed and changed. I disagree that it covers specific use case. It's needed quite often. In "clean" methods it's possible and easy to achieve by just conditionally and sequentially raising `ValidationError`. Why not to have same possibility when using common validators? I'm not sure that creating a wrapper validator will be a good solution because validators in set can vary. Also this will require to change the way it's defined or subclass fields to override this logic, because this is defined in field.
    22
    33As a workaround I can just do a set of calls in form's `clean_import_file` method like that:
Back to Top