Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#27085 closed Cleanup/optimization (fixed)

UI Discrepancy in "Writing your first Django app, part 2"

Reported by: pluralschool Owned by: Abhishek Bera
Component: Documentation Version: 1.10
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: yes UI/UX: no

Description (last modified by pluralschool)

Hi

Here's reporting UI Discrepancy in "Writing your first Django app, part 2" tutorial. Please refer to the screenshots (Tutorial.JPG and Actual.JPG).

As per https://docs.djangoproject.com/en/1.10/intro/tutorial02/, "Home › Polls › Questions" is shown displaying Check Box: "QUESTION TEXT"(vide Tutorial.JPG). However, the actual out from the code displays Check Box: "QUESTION" (vide Actual.JPG). The code was run on the following environments:

CentOS 7.1 64-Bit
Django 1.9.6
Python 2.7.5

Windows 8.1 64-Bit
Django 1.10
Python 2.7.11

Windows 7 64-Bit
Django 1.8.2
Python 3.4.3

Thanks

Attachments (2)

Tutorial.JPG (32.8 KB ) - added by pluralschool 8 years ago.
Actual.JPG (78.4 KB ) - added by pluralschool 8 years ago.

Download all attachments as: .zip

Change History (19)

by pluralschool, 8 years ago

Attachment: Tutorial.JPG added

by pluralschool, 8 years ago

Attachment: Actual.JPG added

comment:1 by pluralschool, 8 years ago

Description: modified (diff)

comment:2 by Baptiste Mispelon, 8 years ago

Triage Stage: UnreviewedAccepted

Hi,

Indeed, the screenshot in the tutorial is incorrect.

Thanks for spotting that.

comment:3 by Baptiste Mispelon, 8 years ago

Easy pickings: set

Regenerating the image will be tricky because we want to match the style of the others.

However, in this instance we should be able to use an image-editing software to crop out the word "TEXT" and replace it with a solid gray backround.

The image to edit is located in docs/intro/_images/admin04t.png.

comment:4 by Tim Graham, 8 years ago

See also Minimizing images for post processing to do on the image.

comment:5 by Abhishek Bera, 8 years ago

Owner: changed from nobody to Abhishek Bera
Status: newassigned

comment:6 by Abhishek Bera, 8 years ago

New image added.
Bug fixed on branch berabhishek:ticket_27085

Version 0, edited 8 years ago by Abhishek Bera (next)

comment:7 by Abhishek Bera, 8 years ago

Resolution: fixed
Status: assignedclosed

comment:8 by Claude Paroz, 8 years ago

Resolution: fixed
Status: closednew

Please don't set the resolution to fixed before the patch is committed to Django master.

Also could you please make a pull request, then set the Has patch flag?

comment:9 by Baptiste Mispelon, 8 years ago

As Claude said, please create a pull request from your branch, it will make it easier for us to leave comments on it (there should be a big green button on https://github.com/django/django/compare/master...berabhishek:ticket_27085).

Regarding the image, I see two issues:

1) The size is different from the original. Please crop/resize it so that your image is the same size as the old one (930x279).
2) The "Action" select menu looks different from the old one and is now inconsistent with the other screenshots. This is the problem I described in my comment earlier.

Thanks.

in reply to:  8 comment:10 by Abhishek Bera, 8 years ago

Replying to claudep:

Please don't set the resolution to fixed before the patch is committed to Django master.

Also could you please make a pull request, then set the Has patch flag?

Thank you very much... point taken...

comment:11 by Abhishek Bera, 8 years ago

Status: newassigned

in reply to:  9 comment:12 by Abhishek Bera, 8 years ago

Replying to bmispelon:

As Claude said, please create a pull request from your branch, it will make it easier for us to leave comments on it (there should be a big green button on https://github.com/django/django/compare/master...berabhishek:ticket_27085).

Regarding the image, I see two issues:

1) The size is different from the original. Please crop/resize it so that your image is the same size as the old one (930x279).
2) The "Action" select menu looks different from the old one and is now inconsistent with the other screenshots. This is the problem I described in my comment earlier.

Thanks.

Thank You very much for pointing them out...

comment:13 by Abhishek Bera, 8 years ago

Has patch: set

comment:14 by Abhishek Bera, 8 years ago

The discrepancy has been resolved in the branch berabhishek:ticket_27085

Last edited 8 years ago by Abhishek Bera (previous) (diff)

comment:15 by Baptiste Mispelon, 8 years ago

Patch needs improvement: set

Hi,

Thanks for opening the pull request and fixing the size issue.
However, you haven't addressed my issue number 2: the form elements in your new screenshot are now inconsistent with the other screenshots on the page (checbox, select).

comment:16 by Tim Graham <timograham@…>, 8 years ago

Resolution: fixed
Status: assignedclosed

In f878b86:

[1.10.x] Fixed #27085 -- Corrected a screenshot in the tutorial.

Backport of 44c306218ff5f1b1748040ee3ffd767c4bc33533 from master

comment:17 by Tim Graham <timograham@…>, 8 years ago

In 44c30621:

Fixed #27085 -- Corrected a screenshot in the tutorial.

Note: See TracTickets for help on using tickets.
Back to Top