#27085 closed Cleanup/optimization (fixed)
UI Discrepancy in "Writing your first Django app, part 2"
Reported by: | pluralschool | Owned by: | Abhishek Bera |
---|---|---|---|
Component: | Documentation | Version: | 1.10 |
Severity: | Normal | Keywords: | |
Cc: | Triage Stage: | Accepted | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | yes |
Easy pickings: | yes | UI/UX: | no |
Description (last modified by )
Hi
Here's reporting UI Discrepancy in "Writing your first Django app, part 2" tutorial. Please refer to the screenshots (Tutorial.JPG and Actual.JPG).
As per https://docs.djangoproject.com/en/1.10/intro/tutorial02/, "Home › Polls › Questions" is shown displaying Check Box: "QUESTION TEXT"(vide Tutorial.JPG). However, the actual out from the code displays Check Box: "QUESTION" (vide Actual.JPG). The code was run on the following environments:
CentOS 7.1 64-Bit
Django 1.9.6
Python 2.7.5
Windows 8.1 64-Bit
Django 1.10
Python 2.7.11
Windows 7 64-Bit
Django 1.8.2
Python 3.4.3
Thanks
Attachments (2)
Change History (19)
by , 8 years ago
Attachment: | Tutorial.JPG added |
---|
by , 8 years ago
Attachment: | Actual.JPG added |
---|
comment:1 by , 8 years ago
Description: | modified (diff) |
---|
comment:2 by , 8 years ago
Triage Stage: | Unreviewed → Accepted |
---|
comment:3 by , 8 years ago
Easy pickings: | set |
---|
Regenerating the image will be tricky because we want to match the style of the others.
However, in this instance we should be able to use an image-editing software to crop out the word "TEXT" and replace it with a solid gray backround.
The image to edit is located in docs/intro/_images/admin04t.png
.
comment:5 by , 8 years ago
Owner: | changed from | to
---|---|
Status: | new → assigned |
comment:6 by , 8 years ago
New image added.
Bug fixed on branch berabhishek:ticket_27085
This is my first patch ... Can anybody review it and suggest what to do next?
comment:7 by , 8 years ago
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
follow-up: 10 comment:8 by , 8 years ago
Resolution: | fixed |
---|---|
Status: | closed → new |
Please don't set the resolution to fixed before the patch is committed to Django master.
Also could you please make a pull request, then set the Has patch
flag?
follow-up: 12 comment:9 by , 8 years ago
As Claude said, please create a pull request from your branch, it will make it easier for us to leave comments on it (there should be a big green button on https://github.com/django/django/compare/master...berabhishek:ticket_27085).
Regarding the image, I see two issues:
1) The size is different from the original. Please crop/resize it so that your image is the same size as the old one (930x279).
2) The "Action" select menu looks different from the old one and is now inconsistent with the other screenshots. This is the problem I described in my comment earlier.
Thanks.
comment:10 by , 8 years ago
Replying to claudep:
Please don't set the resolution to fixed before the patch is committed to Django master.
Also could you please make a pull request, then set the
Has patch
flag?
Thank you very much... point taken...
comment:11 by , 8 years ago
Status: | new → assigned |
---|
comment:12 by , 8 years ago
Replying to bmispelon:
As Claude said, please create a pull request from your branch, it will make it easier for us to leave comments on it (there should be a big green button on https://github.com/django/django/compare/master...berabhishek:ticket_27085).
Regarding the image, I see two issues:
1) The size is different from the original. Please crop/resize it so that your image is the same size as the old one (930x279).
2) The "Action" select menu looks different from the old one and is now inconsistent with the other screenshots. This is the problem I described in my comment earlier.
Thanks.
Thank You very much for pointing them out...
comment:13 by , 8 years ago
Has patch: | set |
---|
comment:14 by , 8 years ago
The bug is fixed in the branch berabhishek:ticket_27085
comment:15 by , 8 years ago
Patch needs improvement: | set |
---|
Hi,
Thanks for opening the pull request and fixing the size issue.
However, you haven't addressed my issue number 2: the form elements in your new screenshot are now inconsistent with the other screenshots on the page (checbox, select).
Hi,
Indeed, the screenshot in the tutorial is incorrect.
Thanks for spotting that.