Changes between Initial Version and Version 1 of Ticket #27074, comment 8
- Timestamp:
- Aug 18, 2016, 12:32:22 PM (8 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #27074, comment 8
initial v1 1 Also, for future reference, an argument for putting the logic in the base implementation is that it's the base implementation that sets `self.connection` to `None` in the first place (in the finally block of its `close()` method, when not in an atomic block). See [https://github.com/django/django/blob/76ab8851181675a59425f9637bdbf3f2de95f6f1/django/db/backends/base/base.py#L266 here] for the code.1 For future reference, an argument for putting the logic in the base implementation is that it's the base implementation that sets `self.connection` to `None` in the first place (in the finally block of its `close()` method, when not in an atomic block). See [https://github.com/django/django/blob/76ab8851181675a59425f9637bdbf3f2de95f6f1/django/db/backends/base/base.py#L266 here] for the code.