#26893 closed Bug (worksforme)
Database creation failed using PostGis and Django
Reported by: | Surbier Christophe | Owned by: | nobody |
---|---|---|---|
Component: | GIS | Version: | 1.8 |
Severity: | Normal | Keywords: | |
Cc: | Triage Stage: | Unreviewed | |
Has patch: | no | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
I'm trying to create my database tables (python manage.py migrate) using Postgis. However it fails because the driver try to connect do default database "postgres" which is not my default name. I'm using django==1.8 and psycopg2==2.6.2
If i look the documentation of psycopg (http://initd.org/psycopg/docs/module.html) The basic connection parameters are:
dbname – the database name (only in the dsn string)
database – the database name (only as keyword argument)
user – user name used to authenticate
password – password used to authenticate
host – database host address (defaults to UNIX socket if not provided)
port – connection port number (defaults to 5432 if not provided)
Here is my database connection:
DATABASES = { 'default': { 'ENGINE': 'django.contrib.gis.db.backends.postgis', 'NAME': '<mydatabase>', 'USER': '<myuser>', 'PASSWORD': '<mypassword>', 'HOST': ‘bdsn15qbq8xaqoa-postgresql.services.clever-cloud.com' 'PORT': '5432', 'URI':'postgis://myuser:mypassword@bdsn15qbq8xaqoa-postgresql.services.clever-cloud.com:5432/bdsn15qbq8xaqoa' } }
I have added some trace to the connexion and as we can see, the driver uses postgres as database name instead of the one specified in the config file.
[('dbname', 'postgres'), ('user', 'myuser'), ('password', 'mypassword'), ('host', 'bdsn15qbq8xaqoa-postgresql.services.clever-cloud.com'), ('port', '5432’)]
After some research, i have edited the file :
vi django/db/backends/postgresql_psycopg2/base.py
Function :
def get_connection_params(self): settings_dict = self.settings_dict # None may be used to connect to the default 'postgres' db if settings_dict['NAME'] == '': from django.core.exceptions import ImproperlyConfigured raise ImproperlyConfigured( "settings.DATABASES is improperly configured. " "Please supply the NAME value.") conn_params = { 'database': settings_dict['NAME'] or 'postgres', } print settings_dict conn_params.update(settings_dict['OPTIONS']) conn_params.pop('isolation_level', None) if settings_dict['USER']: conn_params['user'] = settings_dict['USER'] if settings_dict['PASSWORD']: conn_params['password'] = force_str(settings_dict['PASSWORD']) if settings_dict['HOST']: conn_params['host'] = settings_dict['HOST'] if settings_dict['PORT']: conn_params['port'] = settings_dict['PORT'] return conn_params
and added:
if settings_dict['DBNAME']: conn_params['dbname'] = settings_dict['DBNAME']
Now if i relaunch the database creation : python manage.py migrate it is working fine using the good connection URI.
[('dbname', 'mydatabase'), ('user', 'myuser'), ('password', 'mypassword'), ('host', 'bdsn15qbq8xaqoa-postgresql.services.clever-cloud.com'), ('port', '5432’)
Thanks a lot
Christophe
Change History (6)
comment:1 by , 8 years ago
follow-up: 3 comment:2 by , 8 years ago
Resolution: | → worksforme |
---|---|
Status: | new → closed |
I guess that in your use case, you should follow the instructions and create your PostGIS database beforehand.
https://docs.djangoproject.com/en/1.9/ref/contrib/gis/install/postgis/#creating-a-spatial-database
comment:3 by , 8 years ago
Replying to claudep:
I guess that in your use case, you should follow the instructions and create your PostGIS database beforehand.
https://docs.djangoproject.com/en/1.9/ref/contrib/gis/install/postgis/#creating-a-spatial-database
it doesn't help. How can i create a database and then update my models with PostGis specific fields (such as models.PointField) if i can't run migrations too ? Since the connexion fails. Why is the driver trying to connect with a default "postgres" user ? This is not what it is in my settings. I don't understand.
Thanks
Christophe
follow-up: 5 comment:4 by , 8 years ago
You can run migrations fine, you just have to run the "CREATE DATABASE"/"CREATE EXTENSION" commands first.
As you didn't provide any traceback, I cannot tell you much about the reason of the failing connection, but at some point, if Django has to talk to PostgreSQL without having to specify a database, it defaults to the postgres
database (which is generally readable by all users in most setups), typically in a situation when it has to create a database, hence my recommendation to create it yourself beforehand.
comment:5 by , 8 years ago
Replying to claudep:
You can run migrations fine, you just have to run the "CREATE DATABASE"/"CREATE EXTENSION" commands first.
As you didn't provide any traceback, I cannot tell you much about the reason of the failing connection, but at some point, if Django has to talk to PostgreSQL without having to specify a database, it defaults to the
postgres
database (which is generally readable by all users in most setups), typically in a situation when it has to create a database, hence my recommendation to create it yourself beforehand.
Thanks for your answer but the database had been already created by the PAAS Provider and the PostGis extension too. Now i'm just trying to create my tables but the connexion failed (even if a database name is provided as you can see in my settings file). In fact on my local machine with a PostgreSQL everything work fine. But it doesn't work when i try to launch with my provider settings. Because they don't give access to default postgres database. And if i edit the psycopg2 file base.py as i said, and add the DBNAME in the code, then it is working..
comment:6 by , 8 years ago
Thanks for the traceback.
This code path has changed in Django 1.9 as we dropped support for PostGIS 1.5 and the query for any postgis template disappeared.
If you have to stick with 1.8, I guess patching Django is the best solution in your case.
Just a precision. I don't have access to the default postgres database. I'm using a PAS provider and my user only have access to my database not the "prostgres" default database. So i think it could be the origin of the bug.
Christophe