UnicodeDecodeError when writing unicode to stdout of management command

[Darren Hobbs]

In a management command in Python 2.7, if you include unicode characters when writing to stdout (with self.stdout.write) you will get a UnicodeDecodeError

# coding=utf-8
from __future__ import absolute_import, unicode_literals

import sys

import pytest
from django.core.management.base import OutputWrapper
from django.utils.encoding import smart_bytes


def test_bad_unicode_names():
    bad_name = smart_bytes(u'£')
    ow = OutputWrapper(sys.stdout)
    with pytest.raises(UnicodeDecodeError):
        ow.write(bad_name)

[Tim Graham]

How do you end up with a situation where you cast a unicode string with non-ASCII characters to bytes?

[Darren Hobbs]

The string came from the db. The actual error came from django/core/management/base.py", line 111, in write

[Tim Graham]

So the broken code is self.stdout.write('{}'.format(possibly_unicode_string_from_db)) without unicode_literals?

[Claude Paroz]

Apart from the content of a BinaryField, I don't see how any non-ASCII bytestring can come from the database.

[Tim Graham]

The issue is that the non-ASCII Unicode string from the database is coerced into the bytestring '{}' (basically the same situation as #21933).

[Darren Hobbs]

It's also compounded by the fact that sys.stdout.write copes with it but self.stdout.write doesn't.

[Tim Graham]

It's because OutputWrapper's default ending is u'\n' so we end up comparing bytestring to Unicode in msg.endswith(ending). I'll leave it up to Claude or another Unicode expert about the correct resolution for this.

[Claude Paroz]

@dhobbs It's still a bit mysterious for us how you got the non-ASCII bytestring, that *might* be the bug in the first place. Could you develop a bit more about your use case?

[Tim Graham]

'{}'.format(possibly_unicode_string_from_db) gives str on Python 2.

[Claude Paroz]

>>> print('{}'.format(u'un café ?'))
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
UnicodeEncodeError: 'ascii' codec can't encode character u'\xe9' in position 6: ordinal not in range(128)

[Tim Graham]

I'm using this management command:

# -*- coding: utf-8 -*-
from django.core.management.base import BaseCommand

from polls.models import Question

class Command(BaseCommand):

    def handle(self, *args, **options):
        v = 'Output: %s'.format(Question.objects.latest('id'))
        print(type(v))
        print(v)
        self.stdout.write(v)

with a question with some non-ASCII chars in the name.

[Claude Paroz]

Wow, I realize now that format or % (mod) are calling the __str__ of the model. Please, Python 3, come soon!

[Claude Paroz]

​PR

[Tim Graham]

Tests aren't passing on Windows.

[Tim Graham]

If someone is interested in the fix that Claude proposed, they'll need to debug the Windows test failures and propose an updated patch.

[Tim Graham]

Closing due to the end of Python 2 support in master in a couple weeks.