HashedFilesMixin StaticFileStorage can't handle nested assets

[Joshua Blum]

There seems to be a bug here if there are nested assets. For example, if i have index.js which references a partial index.html, if index.js is processed first, index.html -> index.<hash-key>.html. Then if index.html is processed and rehashed (i.e. this file contains references to index.png), the <hash-key> inside of index.js in incorrect, since index.html was rehashed to account for it's own static assets. It seems like instead of just substituting the pattern here, we need to recursively rehash the file so the ordering is preserved. Thoughts?

[Tim Graham]

Possible related tickets or duplicates: #22353, #24452.

If not, could you provide a test for Django's test suite that demonstrates the issue?

[Joshua Blum]

I think the problem is similar, however the discussions in those tickets lead to a slightly different solution and wouldn't solve the problem as I've described it. This is the first ticket I am submitted, to add a test should I submit a PR or just show an example?

[Tim Graham]

For a test, I usually generate a patch and attach it to the ticket (unless you also plan to immediately start working on a fix, in which case a PR is fine).

[David Sanders]

I've opened a ​WIP PR for this issue. This is a working fix that I've been using in production for 6 months and it works great. If you need an immediate fix joshblum, try that out, the entire storage.py file can be backported by itself (confirmed this works with 1.8.12, should work with 1.9 as well).

[Ed Morley]

From reading the source, the problem described here should be fixed in Django 1.11, thanks to #24452.
If it's not, please could you reopen a new issue with full STR.
Many thanks :-)