Changes between Initial Version and Version 1 of Ticket #26478, comment 3


Ignore:
Timestamp:
Dec 18, 2016, 9:07:35 AM (8 years ago)
Author:
Tim Martin

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #26478, comment 3

    initial v1  
    1 I've created a patch that fixes this by having the `do_for` function validate the variables against known failure cases. However, this isn't the most general solution, since there are lots of other cases of invalid syntax that won't be caught by this. Would it make sense instead to validate tokens against the requirements for Python identifiers as described [https://docs.python.org/3/reference/lexical_analysis.html#identifiers here]?
     1I've created [https://github.com/django/django/pull/7711 a patch] that fixes this by having the `do_for` function validate the variables against known failure cases. However, this isn't the most general solution, since there are lots of other cases of invalid syntax that won't be caught by this. Would it make sense instead to validate tokens against the requirements for Python identifiers as described [https://docs.python.org/3/reference/lexical_analysis.html#identifiers here]?
Back to Top