Missing check for list_editable in admin

[Alasdair Nicol]

Arising from ​http://stackoverflow.com/questions/35456634/

If list_display and list_editable are both lists with a single item, and list_display_links is not set, then the list_editable won't have any effect, because the field will be displayed as a link rather than a form field. We already have admin checks for usage of list_editable, but this case does not appear to be covered.

class CustomAdmin(admin.ModelAdmin):
    list_display = ('status', )
    list_editable = ('status',)  

#22792 is a related ticket.

[Alasdair Nicol]

When I get a chance, I will have a closer look at the code and try to work out what the problem is .

At a first glance, ​ListDisplayEditableTests should have a test case similar to test_list_display_same_as_list_editable, but with list_display_links undefined. In that case, there should be a warning if the first item in list_display is in list_editable.

[Alasdair Nicol]

I've opened a pull request ​https://github.com/django/django/pull/6156/files

The two old unit tests from #22792 still pass following my changes, and I have added an addition test. However, I found it a tricky problem to get my head around, so I'm not 100% certain I got it correct. I've added comments to the pull request to explain my reasoning.

[Tim Graham]

Left a few comments for improvement.

[Alasdair Nicol]

Pull request updated as suggested.

[Alasdair Nicol]

New pull request is ​https://github.com/django/django/pull/6223

[Tim Graham <timograham@…>]

In 65bd053f:

Fixed #26229 -- Improved check for model admin check admin.E124

Refs #22792