Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

#26058 closed Cleanup/optimization (fixed)

Custom storage backend's not entirely decoupled from FileField

Reported by: Korijn van Golen Owned by: nobody
Component: File uploads/storage Version: 1.9
Severity: Normal Keywords: custom storage filefield
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description (last modified by Korijn van Golen)

Let me start by saying that I've implemented custom FileFields that can handle Numpy objects, to provide some convenience methods to access the typed objects.

Later, when implementing a custom storage backend for Azure Storage, I encountered some issues when handling filenames. Cloud storage doesn't behave like local file system storage does. Most of Django's code is agnostic of this problem, except for a small section of FileField:

In Azure, blobs are stored in containers, and are optionally stored in subfolders (known as prefixes in Azure-speak). To be able to use the upload_to property, I need to be able to pass the full path, e.g.:


Unfortunately, FileField strips the directory part and only passes the blob name to my custom storage backend's get_valid_name implementation, where I really need to validate the whole string. I ended up subclassing FileField:

class CloudStorageFileField(FileField):
    Provides some overrides to enable cloud storage backends

    def get_directory_name(self):
        return force_text(

    def get_filename(self, filename):
        return filename

    def generate_filename(self, instance, filename):
        if callable(self.upload_to):
            filename = self.upload_to(instance, filename)
            filename =
            return filename

        return self.get_directory_name() +

As you can see, all I did was remove the local file system related logic. Unfortunately, my custom file fields need to inherit from this class to work with Azure storage, and when I switch to local storage in a different environment, they have to inherit from the regular FileField! This is obviously an undesirable situation, imposed by the tight coupling to local file system logic in the three methods of FileField.

In order to truly decouple this, FileField would need to be a little bit more agnostic about the storage backend. This could be done by moving the generate_filename method to the backend entirely, for example.

I classified this as a bug, as this case shows that you're not entirely able to do anything you want when implementing custom storage backends.

You can see the implementation of both the custom storage backend and the NumpyFileField here:

Your thoughts?

Change History (9)

comment:1 by Korijn van Golen, 8 years ago

Description: modified (diff)

comment:2 by Tim Graham, 8 years ago

Triage Stage: UnreviewedAccepted
Type: BugCleanup/optimization

The main question is whether or not the changes can be made in a backwards compatible fashion.

comment:3 by Korijn van Golen, 8 years ago

How's this?

    def generate_filename(self, instance, filename):
        # allow for customized filename generation
        if hasattr(, 'generate_filename'):
            if callable(self.upload_to):
                filename = self.upload_to(instance, filename)
            filename = force_text(
        # If upload_to is a callable, make sure that the path it returns is
        # passed through get_valid_name() of the underlying storage.
        if callable(self.upload_to):
            directory_name, filename = os.path.split(self.upload_to(instance, filename))
            filename =
            return os.path.normpath(os.path.join(directory_name, filename))

        return os.path.join(self.get_directory_name(), self.get_filename(filename))
Version 0, edited 8 years ago by Korijn van Golen (next)

comment:4 by Korijn van Golen, 8 years ago

Not sure if my edit generated a notification, so, bump. Please see comment:3.

Last edited 8 years ago by Korijn van Golen (previous) (diff)

comment:5 by Tim Graham, 8 years ago

Has patch: set

#26382 is a duplicate with a patch proposed: PR

comment:6 by Tim Graham, 8 years ago

Patch needs improvement: set

comment:7 by Tim Graham, 8 years ago

Patch needs improvement: unset

comment:8 by Tim Graham <timograham@…>, 8 years ago

Resolution: fixed
Status: newclosed

In 914c72b:

Fixed #26058 -- Delegated os.path bits of FileField's filename generation to the Storage.

comment:9 by Tim Graham <timograham@…>, 7 years ago

In 0dfc5479:

Refs #26058 -- Removed deprecated FileField.get_directory_name()/get_filename().

Note: See TracTickets for help on using tickets.
Back to Top