Opened 8 years ago
Last modified 8 years ago
#26024 closed Bug
ConditionalGetMiddleware's ETag is broken — at Version 1
| Reported by: | Sami Fahed | Owned by: | Sami Fahed |
|---|---|---|---|
| Component: | Core (Cache system) | Version: | 1.9 |
| Severity: | Release blocker | Keywords: | Etags |
| Cc: | Triage Stage: | Accepted | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description (last modified by )
ETag support is broken in ConditionalGetMiddleware
django.utils.cache.get_conditional_response's etag argument needs to be *unquoted*, however the etag passed by CommonMiddleware's make_response is quoted or the GZipMiddleware is modifying it while keeping it quoted.
Pull request with Regression Test: https://github.com/django/django/pull/5919
Note:
See TracTickets
for help on using tickets.